On Saturday 05 March 2005 13:47, Jody McIntyre wrote: >On Thu, Mar 03, 2005 at 11:55:09PM +0100, Panagiotis Issaris wrote: >> Adds the missing failure handling for a __copy_to_user call. >> >> >> Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> > >Sorry I didn't notice this sooner, but this was already fixed and > has been sent to Linus (hopefully to appear in 2.6.12.) > >Jody
Jody, Panagiotis; A much more complete patch is already sitting in the bk queue. This is a relatively small piece of that one. You can get it from: <ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11-mm1/broken-out> As the bk-ieee1394.patch you can see there. >> diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c >> linux-2.6.11-pi/drivers/ieee1394/raw1394.c --- >> linux-2.6.11/drivers/ieee1394/raw1394.c 2005-03-02 >> 11:44:26.000000000 +0100 +++ >> linux-2.6.11-pi/drivers/ieee1394/raw1394.c 2005-03-02 >> 15:27:15.000000000 +0100 @@ -443,7 +443,10 @@ static ssize_t >> raw1394_read(struct file req->req.error = RAW1394_ERROR_MEMFAULT; >> } >> } >> - __copy_to_user(buffer, &req->req, sizeof(req->req)); >> + if (__copy_to_user(buffer, &req->req, sizeof(req->req))) >> { + free_pending_request(req); >> + return -EFAULT; >> + } >> >> free_pending_request(req); >> return sizeof(struct raw1394_request); >> >> >> -- >> K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research >> Group http://people.mech.kuleuven.ac.be/~pissaris/ >> >> - >> To unsubscribe from this list: send the line "unsubscribe >> linux-kernel" in the body of a message to >> [EMAIL PROTECTED] >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) 99.34% setiathome rank, not too shabby for a WV hillbilly Yahoo.com attorneys please note, additions to this message by Gene Heskett are: Copyright 2005 by Maurice Eugene Heskett, all rights reserved. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/