On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote: > Use print_hex_dump_debug to have memory properly dumped only when dynamic > debug is enabled.
Not true. Now it prints all the time when !CONFIG_DYNAMIC_DEBUG and CONFIG_PRINTK. > diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h [] > -#ifdef CONFIG_RTS5208_DEBUG > -#define RTSX_DUMP(buf, buf_len) \ > - print_hex_dump(KERN_DEBUG, KBUILD_MODNAME ": ", \ > - DUMP_PREFIX_NONE, 16, 1, (buf), (buf_len), false) > -#else > -#define RTSX_DUMP(buf, buf_len) > -#endif > - > #endif /* __REALTEK_RTSX_TRACE_H */ Before it would not print at all if !CONFIG_RTS5208_DEBUG. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
