Hi, On 07/07/2014 at 17:46:42 +0200, Boris Brezillon wrote : > On Mon, 7 Jul 2014 17:19:11 +0200 > Alexandre Belloni <alexandre.bell...@free-electrons.com> wrote: > > > Atmel SoCs have one or multiple RAM controllers that need one or multiple > > clocks > > to run. > > This driver handle those clocks. > > > > Actually this controller is an SDRAM controller which, depending on the > SoC, might support SDR SDRAMs, DDR SDRAMs or both. > > This is just a nitpick, but if you don't mind I'd rather replace > references to RAMC by SDRAMC (ATMEL_RAMC -> ATMEL_SDRAMC) and just state > that in some cases (at least this is the case for the DDRSDRC available > in at91sam9g45 SoC) it supports both type of SDRAM (DDR and SDR). > > The same goes for the source file name (atmel-ramc.c -> atmel-sdramc.c). >
will do. > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.txt > > b/Documentation/devicetree/bindings/arm/atmel-at91.txt > > index 16f60b41c147..54dc3aefb12a 100644 > > --- a/Documentation/devicetree/bindings/arm/atmel-at91.txt > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.txt > > @@ -61,6 +61,7 @@ RAMC SDRAM/DDR Controller required properties: > > - compatible: Should be "atmel,at91rm9200-sdramc", > > "atmel,at91sam9260-sdramc", > > "atmel,at91sam9g45-ddramc", > > + "atmel,sama5d3-mpddramc", > > - reg: Should contain registers location and length > > For at91sam9263 and at91sam9g45 you must specify 2 entries. > > Shouldn't we move the documentation in > Documentation/devicetree/bindings/memory-controllers/ (though this > should be done in different patch). > I guess we should move it later, to avoid merge conflicts -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
