On 06/26/2014 02:21 PM, Viresh Kumar wrote: > We do report driver's successful {un}registration from cpufreq core, but is > done > with pr_debug() and so this doesn't appear in boot logs. > > Convert this to pr_info() to make it visible in logs. >
While at it, let's also standardize those messages, since they will be more visible now. > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> > --- > drivers/cpufreq/cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 62259d2..63d8f8f 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2468,7 +2468,7 @@ int cpufreq_register_driver(struct cpufreq_driver > *driver_data) > } > > register_hotcpu_notifier(&cpufreq_cpu_notifier); > - pr_debug("driver %s up and running\n", driver_data->name); > + pr_info("driver %s up and running\n", driver_data->name); How about "Registered cpufreq driver: %s\n" > > return 0; > err_if_unreg: > @@ -2499,7 +2499,7 @@ int cpufreq_unregister_driver(struct cpufreq_driver > *driver) > if (!cpufreq_driver || (driver != cpufreq_driver)) > return -EINVAL; > > - pr_debug("unregistering driver %s\n", driver->name); > + pr_info("unregistering driver %s\n", driver->name); And "Unregistered cpufreq driver: %s\n" (Also, its probably a good idea to have 2 prints here, just like we have for cpufreq_register_driver() - one with pr_debug() at the beginning of the function which tells us that we are *about* to register the driver, and then a second print with pr_info() at the end of the function that tells us that we successfully registered the driver. We can do the same thing for unregistration as well.) > > subsys_interface_unregister(&cpufreq_interface); > if (cpufreq_boost_supported()) > Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/