On Thu, Mar 10, 2005 at 09:56:52PM -0800, Andrew Morton wrote: > That's a nice application of semaphores. I can see that there's also a > need to be able to read the value back for reporting purposes. Dang. > > But I guess it's a bit hard to justify adding more infrastructure to > support a single callsite which has a simple alternative. So if you could > please add the separate counter?
It's pretty *small* infrastructure, and it gives me something to whine at people about when they use atomic_read on something that isn't an atomic. > > ... > > > > If this patch isn't accepted, we should get rid of the xfs and 1394 > > hacks and delete sem_getcount (parisc, frv) and sema_count (arm) as they > > are unused. > > True. If we are going to get rid of sem_getcount, could we rename the 'count' variables, at least on i386 and ppc to make it clear that you're not supposed to do this ... maybe to 'count_$ARCH'? -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
