On Mon, 14 Jul 2014 09:20:49 -0400 Johannes Weiner <[email protected]> wrote:
> Reorder the members by input and output, then turn the individual > integers for may_writepage, may_unmap, may_swap, compaction_ready, > hibernation_mode into flags that fit into a single integer. bitfields would be a pretty good fit here. I usually don't like them because of locking concerns with the RMWs, but scan_control is never accessed from another thread. > - if (!sc->may_unmap && page_mapped(page)) > + if (!(sc->flags & MAY_UNMAP) && page_mapped(page)) Then edits such as this are unneeded. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
