On Saturday 12 March 2005 22:41, Frank Sorenson wrote: > Dmitry Torokhov wrote: > | Hi, > | > | here are some changes that freshen I8K driver (Dell Inspiron/Latitude > | platform driver). The patches have been tested on Inspiron 8100. > <snip> > | Please consider for inclusion. > | > | Thanks! > > These patches look pretty good. �A few comments (with a patch--tested on > my Inspiron 9200): > > - The "return i8k_smm(®s) < 0 ? : regs.eax;" construction is nice and > tidy, but it isn't passing on the return value of the called function, > and is returning TRUE or 1 on failure. �This makes it difficult to check > the return value for valid data. �Old behavior returned negative, so > I'll return -1.
Hi, Actually I am not sure what I was thinkinhg when I wrtote it, the correct version should be "return i8k_smm(®s) ? : regs.eax;" since i8k_smm return 0 on success. I will think about dynamically adding attributes... -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
