On Thu, 24 Jul 2014, Peter Zijlstra wrote:
> Subject: irq: Warn when shared interrupts do not match on NO_SUSPEND
>
> When suspend_device_irqs() iterates all descriptors, its pointless if
> one has NO_SUSPEND set while another has not.
>
> Validate on request_irq() that NO_SUSPEND state maches for SHARED
> interrupts.
I'm happy to take that patch, but you are aware that it is going to
break a few things?
25: .... PCI-MSI-edge aerdrv, PCIe PME
Thanks,
tglx
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Signed-off-by: Peter Zijlstra <[email protected]>
> ---
> kernel/irq/manage.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 88657d7bc9dd..27a1fe028afb 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1077,9 +1077,12 @@ __setup_irq(unsigned int irq, struct irq_desc *desc,
> struct irqaction *new)
> * set the trigger type must match. Also all must
> * agree on ONESHOT.
> */
> +
> +#define IRQF_MISMATCH \
> + (IRQF_TRIGGER_MASK | IRQF_ONESHOT | IRQF_NO_SUSPEND)
> +
> if (!((old->flags & new->flags) & IRQF_SHARED) ||
> - ((old->flags ^ new->flags) & IRQF_TRIGGER_MASK) ||
> - ((old->flags ^ new->flags) & IRQF_ONESHOT))
> + ((old->flags ^ new->flags) & IRQF_MISMATCH))
> goto mismatch;
>
> /* All handlers must agree on per-cpuness */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
