On Tue, Jul 29, 2014 at 6:07 PM, David Vrabel <[email protected]> wrote: > On 29/07/14 05:06, Ethan Zhao wrote: >> Use pci device flag operation helper functions when set device >> to assigned or deassigned state. >> >> Signed-off-by: Ethan Zhao <[email protected]> > > Konrad already reviewed this but you've not included his reviewed-by tag. > > I don't understand why we bother with this flag on Xen since we never > use it but: > > Acked-by: David Vrabel <[email protected]> > > I'm expecting this to go via the PCI tree.
Seems Bjorn still holds his bullet for last shot :) > > David > >> --- a/drivers/xen/xen-pciback/pci_stub.c >> +++ b/drivers/xen/xen-pciback/pci_stub.c >> @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref) >> xen_pcibk_config_free_dyn_fields(dev); >> xen_pcibk_config_free_dev(dev); >> >> - dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED; >> + pci_clear_dev_assigned(dev); >> pci_dev_put(dev); >> >> kfree(psdev); >> @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev) >> dev_dbg(&dev->dev, "reset device\n"); >> xen_pcibk_reset_device(dev); >> >> - dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED; >> + pci_set_dev_assigned(dev); >> return 0; >> >> config_release: >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
