On 05/08/14 21:09, David Miller wrote:
From: Zoltan Kiss <[email protected]> Date: Mon, 4 Aug 2014 14:37:14 +0100@@ -3559,6 +3616,14 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev) pkt_dev->last_pkt_size = pkt_dev->skb->len; pkt_dev->allocated_skbs++; pkt_dev->clone_count = 0; /* reset counter */ + + if (netif_needs_gso(pkt_dev->skb, netif_skb_features(pkt_dev->skb))) { + pr_err("Device don't have necessary GSO features! netif_skb_features: %llX summed %u\n", + netif_skb_features(pkt_dev->skb), + pkt_dev->skb->ip_summed); + pkt_dev->sofar++; + goto out; + } } if (pkt_dev->delay && pkt_dev->last_ok)Woe be to the person who actually triggers this condition. This function happens potentially millions of times per second, there is no value in emitting a log message every time.
Indeed, I'll put a ratelimit around it. Zoli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
