Around Thu 07 Aug 2014 14:49:05 +0200 or thereabout, Julia Lawall wrote: > From: Julia Lawall <[email protected]> > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function.
Excellent find, added to this for-linus branch. > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <[email protected]> Acked-by: Hans-Christian Egtvedt <[email protected]> > --- > arch/avr32/boards/hammerhead/flash.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) <snipp diff> -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
