On Thu, 7 Aug 2014 11:13:56 -0700 "Paul E. McKenney" <[email protected]> wrote:
> On Thu, Aug 07, 2014 at 10:52:04AM -0700, Dave Hansen wrote: > > > > From: Dave Hansen <[email protected]> > > > > Dave Jones reported seeing a bug from one of my TLB tracepoints: > > > > http://lkml.kernel.org/r/[email protected] > > > > I've been running these patches for months and never saw this. > > But, a big chunk of my testing, especially with all the debugging > > enabled, was in a vm where intel_idle doesn't work. On the > > systems where I was using intel_idle, I never had lockdep enabled > > and this tracepoint on at the same time. > > > > This patch ensures that whenever we have lockdep available, we do > > _some_ RCU activity at the site of the tracepoint, despite > > whether the tracepoint's condition matches or even if the > > tracepoint itself is completely disabled. This is a bit of a > > hack, but it is pretty self-contained. > > > > I confirmed that with this patch plus lockdep I get the same > > splat as Dave Jones did, but without enabling the tracepoint > > explicitly. > > > > Signed-off-by: Dave Hansen <[email protected]> > > Cc: Dave Jones <[email protected]>, > > Cc: [email protected] > > Cc: Steven Rostedt <[email protected]> > > Cc: Ingo Molnar <[email protected]> > > Looks good to me, but I must defer to Steven on this one. > Looks fine. I can add it to my 3.18 queue. Paul, want to send me an "Acked-by"? Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
