On Wed, Aug 13, 2014 at 02:11:09AM +0100, Rohit Vaswani wrote: > Currently, the CPU_STARTING notifiers would observe an incorrect sibling > mask since the notifier chain is called before the topology masks are updated > for the new cpu. > Update the topology masks before calling the notifier chain to fix this > problem. > > Signed-off-by: Rohit Vaswani <[email protected]> > --- > arch/arm/kernel/smp.c | 4 ++-- > arch/arm64/kernel/smp.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c > index 7c4fada..0e2237c 100644 > --- a/arch/arm/kernel/smp.c > +++ b/arch/arm/kernel/smp.c > @@ -363,12 +363,12 @@ asmlinkage void secondary_start_kernel(void) > if (smp_ops.smp_secondary_init) > smp_ops.smp_secondary_init(cpu); > > + smp_store_cpu_info(cpu); > + > notify_cpu_starting(cpu); > > calibrate_delay(); > > - smp_store_cpu_info(cpu); > -
Hmm, smp_store_cpu_info takes a copy of loops_per_jiffy. Are you sure it's safe to move the call before calibrate_delay? Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
