On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote: > sd_print_sense_hdr() calls scsi_show_extd_sense(), > but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). > We can get same result, so we delete it. > > Note: > Calling scsi_show_extd_sense() is introduced in fdd8b297. > > Signed-off-by: Yoshihiro YUNOMAE <[email protected]> > Cc: Hannes Reinecke <[email protected]> > Cc: Doug Gilbert <[email protected]> > Cc: Martin K. Petersen <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: "James E.J. Bottomley" <[email protected]> > Cc: Hidehiro Kawai <[email protected]> > Cc: Masami Hiramatsu <[email protected]> > --- > drivers/scsi/sd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 8d7204a..22dd214 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3286,8 +3286,6 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp, > struct scsi_sense_hdr *sshdr) > { > scsi_print_sense_hdr(sdkp->device, sdkp->disk->disk_name, sshdr); > - scsi_show_extd_sense(sdkp->device, sdkp->disk->disk_name, > - sshdr->asc, sshdr->ascq); > } > > static void sd_print_result(struct scsi_disk *sdkp, int result) > > --
Looks fine, but again, Hannes should probably update his tree. Reviewed-by: Ewan D. Milne <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
