From: Carolyn Wyborny <[email protected]>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit d1c17d806b6a52ff020322bec457717a91ea50a9 upstream.

This patch calls code to set the master/slave mode for all m88 gen 2
PHY's. This patch also removes the call to this function for I210 devices
only from the function that is not called by I210 devices.

Signed-off-by: Carolyn Wyborny <[email protected]>
Tested-by: Jeff Pieper  <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
---
 drivers/net/ethernet/intel/igb/e1000_phy.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c 
b/drivers/net/ethernet/intel/igb/e1000_phy.c
index 556da81ab092..ad2b74d95138 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -708,11 +708,6 @@ s32 igb_copper_link_setup_m88(struct e1000_hw *hw)
                hw_dbg("Error committing the PHY changes\n");
                goto out;
        }
-       if (phy->type == e1000_phy_i210) {
-               ret_val = igb_set_master_slave_mode(hw);
-               if (ret_val)
-                       return ret_val;
-       }
 
 out:
        return ret_val;
@@ -806,6 +801,9 @@ s32 igb_copper_link_setup_m88_gen2(struct e1000_hw *hw)
                hw_dbg("Error committing the PHY changes\n");
                return ret_val;
        }
+       ret_val = igb_set_master_slave_mode(hw);
+       if (ret_val)
+               return ret_val;
 
        return 0;
 }
-- 
2.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to