On Mon, Mar 21, 2005 at 12:12:32AM +0100, Adrian Bunk wrote:
> On Sun, Mar 20, 2005 at 05:42:34PM -0500, Dave Jones wrote:
> > On Sun, Mar 20, 2005 at 08:25:49PM +0100, Adrian Bunk wrote:
> > > Do we really need a global variable that does only hold the value of
> > > NR_CPUS?
> >
> > Yes.
> >
> > NR_CPUS = compile time
> > maxcpus = boot command line at runtime.
>
> If this is how is was expected to work - it isn't exactly what is
> currently implemented.
It's ugly, as its setting the same thing in two different places, but
I don't see any obvious reason why it won't work.
> The function maxcpus in init/main.c sets a static variable max_cpus -
> not the global variable maxcpus in the mpparse.c files.
Both variables are used differently. The arch specific var is only
used for HT descrimination. The init/main.c one is used for smp bringup.
> How should it be?
>
> Should max_cpus in init/main.c become global and replace the maxcpus
> from the mpparse.c files?
I'd just leave it as it is, as it seems to be working right now.
Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
