From: Dariusz Marcinkiewicz <rek...@newterm.pl>
Date: Fri, 15 Aug 2014 17:49:41 +0200
> This cuts down on the number of debug information spit out by
> the driver. Some of the potentially useful debug info gets exposed
> by debugfs.
>
> Signed-off-by: Dariusz Marcinkiewicz <rek...@newterm.pl>
I think you should just flat out remove a lot of this stuff:
> +static struct debugfs_reg32 ec_bhf_debugfs_mii_regs[] = {
> + {
> + .name = "link-status",
> + .offset = MII_LINK_STATUS
> + }
> +};
This is completely unnecessary, if you want to export MII register
values to the user, we have a mechanism for that, via the SIOCGMII*
ioctls.
> +static struct debugfs_reg32 ec_bhf_debugfs_fifo_regs[] = {
> + {
> + .name = "fifo-tx",
> + .offset = FIFO_TX_REG
> + },
> + {
> + .name = "fifo-rx",
> + .offset = FIFO_RX_REG
> + }
> +};
You can export chip register values via the ethtool register dump API.
Simply implement ethtool_ops->get_regs_len and ethtool_ops->get_regs
and off you go.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
