On Mon, 21 Mar 2005 13:44:07 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Tue, Mar 15, 2005 at 02:25:42PM +0100, Kenan Esau wrote: > > Here is a new version of the patch: > > - minimal changes > > - reintroduced DMI-probing > > > > I had a look at the synaptic-sources to see how the pass-through-mode is > > implemented. We'll see if something similar to this also works with the > > lifebook. > > Thanks, I applied this version of the patch to my tree. It'll appear in > next -mm, and in 2.6.13. >
There are couple of things that I an concerned with: 1. I don't like that it overrides meaning of max_proto parameter to be exactly the protocol specified. However, if you take my psmouse protocol switching through sysfs patch we can drop that change and require that non auto-detectable protocols be activated through sysfs after loading the driver. 2. It looks like it bypasses rate and resolution setting in psmouse_initialize. What was the reason for it? Does setting rate or resolution disturbs lifebook mode? If so the driver has to implement it's own set_rate and set_resolution handlers so when one tries to change rate from userspace (through sysfs) the request would be ignored. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
