On 08/22/14 10:04, Jeff Mahoney wrote: > On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >> We should not select SPI bus when sub-driver auto-select is >> selected. That option is meant for auto-selecting all possible >> ancillary drivers used for selected board driver. Ancillary >> drivers should define needed dependencies itself. >> >> I2C and I2C_MUX are still selected here for a reason described on >> commit 347f7a3763601d7b466898d1f10080b7083ac4a3 >> >> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a >> >> Reported-by: Jeff Mahoney <je...@suse.com> >> Signed-off-by: Antti Palosaari <cr...@iki.fi> >> --- >> drivers/media/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >> index f60bad4..3c89fcb 100644 >> --- a/drivers/media/Kconfig >> +++ b/drivers/media/Kconfig >> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT >> depends on HAS_IOMEM >> select I2C >> select I2C_MUX >> - select SPI >> default y >> help >> By default, a media driver auto-selects all possible ancillary > > FWIW, in the patch I used locally, I also did a 'select SPI' in the > MSI2500 driver since it wouldn't otherwise be obvious that a USB device > depends on SPI.
It already has depends on SPI. That should be enough. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
