On Sat, Aug 23, 2014 at 05:50:28PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia.law...@lip6.fr>
>
> Use c99 initializers for structures.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
>
> struct i1 {
> fs
> T fld;
> ...};
>
> @bad@
> identifier decl.i1,i2;
> expression e;
> initializer list[decl.n] is;
> @@
>
> struct i1 i2 = { is,
> + .fld = e
> - e
> ,...};
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Reviewed-by: Josh Triplett <j...@joshtriplett.org>
> v2: Move close braces down to the next line and add trailing commas, as
> suggested by Josh Triplett.
>
> diff --git a/drivers/video/fbdev/aty/aty128fb.c
> b/drivers/video/fbdev/aty/aty128fb.c
> index ff60701..aedf2fb 100644
> --- a/drivers/video/fbdev/aty/aty128fb.c
> +++ b/drivers/video/fbdev/aty/aty128fb.c
> @@ -324,14 +324,61 @@ struct aty128_meminfo {
> };
>
> /* various memory configurations */
> -static const struct aty128_meminfo sdr_128 =
> - { 4, 4, 3, 3, 1, 3, 1, 16, 30, 16, "128-bit SDR SGRAM (1:1)" };
> -static const struct aty128_meminfo sdr_64 =
> - { 4, 8, 3, 3, 1, 3, 1, 17, 46, 17, "64-bit SDR SGRAM (1:1)" };
> -static const struct aty128_meminfo sdr_sgram =
> - { 4, 4, 1, 2, 1, 2, 1, 16, 24, 16, "64-bit SDR SGRAM (2:1)" };
> -static const struct aty128_meminfo ddr_sgram =
> - { 4, 4, 3, 3, 2, 3, 1, 16, 31, 16, "64-bit DDR SGRAM" };
> +static const struct aty128_meminfo sdr_128 = {
> + .ML = 4,
> + .MB = 4,
> + .Trcd = 3,
> + .Trp = 3,
> + .Twr = 1,
> + .CL = 3,
> + .Tr2w = 1,
> + .LoopLatency = 16,
> + .DspOn = 30,
> + .Rloop = 16,
> + .name = "128-bit SDR SGRAM (1:1)",
> +};
> +
> +static const struct aty128_meminfo sdr_64 = {
> + .ML = 4,
> + .MB = 8,
> + .Trcd = 3,
> + .Trp = 3,
> + .Twr = 1,
> + .CL = 3,
> + .Tr2w = 1,
> + .LoopLatency = 17,
> + .DspOn = 46,
> + .Rloop = 17,
> + .name = "64-bit SDR SGRAM (1:1)",
> +};
> +
> +static const struct aty128_meminfo sdr_sgram = {
> + .ML = 4,
> + .MB = 4,
> + .Trcd = 1,
> + .Trp = 2,
> + .Twr = 1,
> + .CL = 2,
> + .Tr2w = 1,
> + .LoopLatency = 16,
> + .DspOn = 24,
> + .Rloop = 16,
> + .name = "64-bit SDR SGRAM (2:1)",
> +};
> +
> +static const struct aty128_meminfo ddr_sgram = {
> + .ML = 4,
> + .MB = 4,
> + .Trcd = 3,
> + .Trp = 3,
> + .Twr = 2,
> + .CL = 3,
> + .Tr2w = 1,
> + .LoopLatency = 16,
> + .DspOn = 31,
> + .Rloop = 16,
> + .name = "64-bit DDR SGRAM",
> +};
>
> static struct fb_fix_screeninfo aty128fb_fix = {
> .id = "ATY Rage128",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
