On Fri, Aug 29, 2014 at 01:13:47PM +0200, walter harms wrote: > > > Am 29.08.2014 10:42, schrieb Dan Carpenter: > > This is untrusted user data from vmci_host_do_send_datagram() so the > > VMCI_DG_SIZE() macro can have an integer overflow. > > > > Signed-off-by: Dan Carpenter <[email protected]> > > > > diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c > > b/drivers/misc/vmw_vmci/vmci_datagram.c > > index f3cdd90..8226652 100644 > > --- a/drivers/misc/vmw_vmci/vmci_datagram.c > > +++ b/drivers/misc/vmw_vmci/vmci_datagram.c > > @@ -328,7 +328,8 @@ int vmci_datagram_dispatch(u32 context_id, > > > > BUILD_BUG_ON(sizeof(struct vmci_datagram) != 24); > > > > - if (VMCI_DG_SIZE(dg) > VMCI_MAX_DG_SIZE) { > > + if (dg->payload_size > VMCI_MAX_DG_SIZE || > > + VMCI_DG_SIZE(dg) > VMCI_MAX_DG_SIZE) { > > pr_devel("Payload (size=%llu bytes) too big to send\n", > > (unsigned long long)dg->payload_size); > > return VMCI_ERROR_INVALID_ARGS; > > Are your sure about that ">" ? maybe ">=" was intended ?
Yes, I'm sure. As a rule of thumb, > is used for size comparisons and >= is used for index comparisons. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
