On Mon, Sep 08, 2014 at 05:10:12PM +0900, Masahiro Yamada wrote: > We should use parentheses only when they are necessary > or they really improve the readability. > > Signed-off-by: Masahiro Yamada <[email protected]>
This seems fine; none of these parentheses are needed, since the relative precedence of the relevant operators is always clear. Reviewed-by: Josh Triplett <[email protected]> > > drivers/mtd/nand/denali.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index d37c2e1..ed37b76 100644 > --- a/drivers/mtd/nand/denali.c > +++ b/drivers/mtd/nand/denali.c > @@ -267,10 +267,10 @@ static void nand_onfi_timing_set(struct > denali_nand_info *denali, > > acc_clks = CEIL_DIV(Trea[mode], CLK_X); > > - while (((acc_clks * CLK_X) - Trea[mode]) < 3) > + while (acc_clks * CLK_X - Trea[mode] < 3) > acc_clks++; > > - if ((data_invalid - acc_clks * CLK_X) < 2) > + if (data_invalid - acc_clks * CLK_X < 2) > dev_warn(denali->dev, "%s, Line %d: Warning!\n", > __FILE__, __LINE__); > > @@ -285,7 +285,7 @@ static void nand_onfi_timing_set(struct denali_nand_info > *denali, > cs_cnt = 1; > > if (Tcea[mode]) { > - while (((cs_cnt * CLK_X) + Trea[mode]) < Tcea[mode]) > + while (cs_cnt * CLK_X + Trea[mode] < Tcea[mode]) > cs_cnt++; > } > > @@ -295,8 +295,8 @@ static void nand_onfi_timing_set(struct denali_nand_info > *denali, > #endif > > /* Sighting 3462430: Temporary hack for MT29F128G08CJABAWP:B */ > - if ((ioread32(denali->flash_reg + MANUFACTURER_ID) == 0) && > - (ioread32(denali->flash_reg + DEVICE_ID) == 0x88)) > + if (ioread32(denali->flash_reg + MANUFACTURER_ID) == 0 && > + ioread32(denali->flash_reg + DEVICE_ID) == 0x88) > acc_clks = 6; > > iowrite32(acc_clks, denali->flash_reg + ACC_CLKS); > @@ -577,7 +577,7 @@ static void denali_set_intr_modes(struct denali_nand_info > *denali, > */ > static inline bool is_flash_bank_valid(int flash_bank) > { > - return (flash_bank >= 0 && flash_bank < 4); > + return flash_bank >= 0 && flash_bank < 4; > } > > static void denali_irq_init(struct denali_nand_info *denali) > @@ -1103,7 +1103,7 @@ static int write_page(struct mtd_info *mtd, struct > nand_chip *chip, > "timeout on write_page (type = %d)\n", > raw_xfer); > denali->status = > - (irq_status & INTR_STATUS__PROGRAM_FAIL) ? > + irq_status & INTR_STATUS__PROGRAM_FAIL ? > NAND_STATUS_FAIL : PASS; > } > > @@ -1296,7 +1296,7 @@ static int denali_erase(struct mtd_info *mtd, int page) > irq_status = wait_for_irq(denali, INTR_STATUS__ERASE_COMP | > INTR_STATUS__ERASE_FAIL); > > - return (irq_status & INTR_STATUS__ERASE_FAIL) ? NAND_STATUS_FAIL : PASS; > + return irq_status & INTR_STATUS__ERASE_FAIL ? NAND_STATUS_FAIL : PASS; > } > > static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col, > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
