> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Hartmut Knaack > Sent: 06 September, 2014 15:12 > To: Tirdea, Irina; Jonathan Cameron; [email protected] > Cc: Lars-Peter Clausen; Peter Meerwald; Srinivas Pandruvada; > [email protected] > Subject: Re: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is > defined > > Irina Tirdea schrieb: > > When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power > > off the device, bmg160_set_power_state will call pm_runtime_put_autosuspend, > > which is not implemented (wil return -ENOSYS). > > > > Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined. > Unless there is anything more to come, what about putting the #ifdef into > first line inside bmg160_set_power_state() and just an > #endif before the return 0 at the end? Saves 5 lines.
Thanks for the suggestion! Will fix it in v2. > > Signed-off-by: Irina Tirdea <[email protected]> > > Reviewed-by: Srinivas Pandruvada <[email protected]> > > --- Thanks, Irina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

