Added new warning DUMMY_LABEL in checkpatch.pl. This warns if return statement is encountered just after goto label target like "out:". In such scenario it is best to call "return;" directly instead of "goto out;"
Signed-off-by: Nitin Kuppelur <[email protected]> --- scripts/checkpatch.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b602ed2..399c2b5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3798,10 +3798,14 @@ sub process { if ($sline =~ /^[ \+]}\s*$/ && $prevline =~ /^\+\treturn\s*;\s*$/ && $linenr >= 3 && - $lines[$linenr - 3] =~ /^[ +]/ && - $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) { - WARN("RETURN_VOID", - "void function return statements are not generally useful\n" . $hereprev); + $lines[$linenr - 3] =~ /^[ +]/) { + if ($lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) { + WARN("RETURN_VOID", + "void function return statements are not generally useful\n" . $hereprev); + } elsif ($lines[$linenr - 3] =~ /^[ +]\s*$Ident\s*:/) { + WARN("DUMMY_LABEL", + "labels doing nothing are not generally useful\n" . $hereprev); + } } # if statements using unnecessary parentheses - ie: if ((foo == bar)) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
