Hi Tim, On Tue, Sep 16, 2014 at 12:49:22PM -0600, [email protected] wrote: > From: Tim Gardner <[email protected]> > > In file included from scripts/sortextable.c:194:0: > scripts/sortextable.c: In function ‘main’: > scripts/sortextable.h:176:3: warning: ‘relocs_size’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > memset(relocs, 0, relocs_size); > ^ > scripts/sortextable.h:106:6: note: ‘relocs_size’ was declared here > int relocs_size; > ^ > In file included from scripts/sortextable.c:192:0: > scripts/sortextable.h:176:3: warning: ‘relocs_size’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > memset(relocs, 0, relocs_size); > ^ > scripts/sortextable.h:106:6: note: ‘relocs_size’ was declared here > int relocs_size; > ^ > > gcc 4.9.1 > > Cc: Andrew Morton <[email protected]> > Cc: Jamie Iles <[email protected]>
Reviewed-by: Jamie Iles <[email protected]> > Signed-off-by: Tim Gardner <[email protected]> > --- > > Is gcc 4.9 dumber then 4.8 ? gcc 4.8 doesn't produce this warning. It's an odd one - I don't see how relocs_size can be uninitialized when relocs is non-null. Your fix looks fine to me though. Jamie > scripts/sortextable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/sortextable.h b/scripts/sortextable.h > index 8fac3fd..ba87004 100644 > --- a/scripts/sortextable.h > +++ b/scripts/sortextable.h > @@ -103,7 +103,7 @@ do_func(Elf_Ehdr *ehdr, char const *const fname, > table_sort_t custom_sort) > Elf_Sym *sort_needed_sym; > Elf_Shdr *sort_needed_sec; > Elf_Rel *relocs = NULL; > - int relocs_size; > + int relocs_size = 0; > uint32_t *sort_done_location; > const char *secstrtab; > const char *strtab; > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
