On Sun, 2014-09-21 at 22:08 -0500, Greg Donald wrote: > On Sun, Sep 21, 2014 at 9:31 PM, Joe Perches <j...@perches.com> wrote: > > On Sun, 2014-09-21 at 20:32 -0500, Greg Donald wrote: > >> Fixing an "open brace '{' following struct go on the same line" error > >> causes a > >> false positive warning "do not add new typedefs". Fix existing typedef > >> false > >> positive warning. > > > > This doesn't work. > > The matching deleted line can be any number of lines above. > > But this fixes the most common case: > > -typedef struct ksock_proto > -{ > +typedef struct ksock_proto {
Meh. I think people are smart enough to work out that this is not a new typedef. > If you're wanting to check more than just $rawlines[$linenr - 3], how > far above does it make sense to go? From what I'm seeing the '{' is > usually on the next line. It's not the most common case working, it's the generic case working. It's in a large block being changed, it doesn't work. If it's checking a file, there are no "-" lines. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/