At Sun, 21 Sep 2014 21:33:39 +0530,
Sudip Mukherjee wrote:
>
> pr_* macros replaced with dev_* as they are more preffered over pr_*.
In this patch, it's not trivial conversion, so it's not bad to spend
more words to explain how you did it. Nevertheless...
(snip)
> diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c
> index fed6e6a..955b2af 100644
> --- a/sound/pci/ctxfi/ctamixer.c
> +++ b/sound/pci/ctxfi/ctamixer.c
> @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr,
> }
> spin_unlock_irqrestore(&mgr->mgr_lock, flags);
> if (err) {
> - pr_err("ctxfi: Can't meet AMIXER resource request!\n");
> + dev_err(((struct hw *)(mgr->mgr.hw))->card->dev,
> + "Can't meet AMIXER resource request!\n");
Do we agree that such a change is too ugly, right? And...
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index 3e29e13..6c185d0 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -186,7 +186,7 @@ static unsigned int convert_format(snd_pcm_format_t
> snd_format,
> case SNDRV_PCM_FORMAT_FLOAT_LE:
> return SRC_SF_F32;
> default:
> - pr_err("ctxfi: not recognized snd format is %d\n",
> + dev_err(card->dev, "ctxfi: not recognized snd format is %d\n",
> snd_format);
You forgot to strip the superfluous prefix in many places.
Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
