On Wed, Sep 24, 2014 at 7:29 AM, Andrey Wagin <[email protected]> wrote: > 2014-09-24 14:31 GMT+04:00 Andrey Wagin <[email protected]>: >> Hi All, > > The problem is in a following commit: > > commit 0c7bf3e8cab7900e17ce7f97104c39927d835469 > Author: Zefan Li <[email protected]> > Date: Sat Sep 20 14:49:10 2014 +0800 > > cgroup: remove redundant variable in cgroup_mount() > > Both pinned_sb and new_sb indicate if a new superblock is needed, > so we can just remove new_sb. > > Note now we must check if kernfs_tryget_sb() returns NULL, because > when it returns NULL, kernfs_mount() may still re-use an existing > superblock, which is just allocated by another concurent mount. >
I guess the check for NULL is incorrect, the comment on kernfs_pin_sb() says: Returns NULL if there's no superblock associated to this kernfs_root, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
