Or someone with the hardware has to test and check that...
On 9/28/14, Stanislaw Gruszka <[email protected]> wrote: > On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: >> This removes the unnecessary overwrite of register 11 in the function, >> rt2800_config_channel as we are already writing a correct value to the >> register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). > What make you sure that overwrite is unnecessary ? > >> >> Signed-off-by: Nicholas Krause <[email protected]> >> --- >> drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c >> b/drivers/net/wireless/rt2x00/rt2800lib.c >> index 893c9d5..fb0ae38 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >> @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct >> rt2x00_dev *rt2x00dev, >> >> if (rf->channel <= 14) { >> rt2800_rfcsr_write(rt2x00dev, 10, 0x90); >> - /* FIXME: RF11 owerwrite ? */ >> - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); > We need a prove that remove is correct, i.e. some reference to > vendor code or spec that current writing register twice with > different values is wrong. > > NACK for the patch. > > Stanislaw > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
