Hi Pramod
On 09/29/2014 03:48 PM, Pramod Gurav wrote:
This change fixes below sparse error,
drivers/pinctrl/pinctrl-st.c:1515:31: error: incompatible types for operation
(>)
drivers/pinctrl/pinctrl-st.c:1515:31: left side has type void [noderef]
<asn:2>*irqmux_base
drivers/pinctrl/pinctrl-st.c:1515:31: right side has type int
The fix is done by removing a check on info->irqmux_base as
info->irqmux_base has already been checked for error when allocating it.
Hence there is no need to redo the check.
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
CC: Linus Walleij <[email protected]>
Cc: Srinivas Kandagatla <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 5475374..ddeaeda 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl
*info,
gpio_irq, st_gpio_irq_handler);
}
- if (info->irqmux_base > 0 || gpio_irq > 0) {
+ if (gpio_irq > 0) {
err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip,
0, handle_simple_irq,
IRQ_TYPE_LEVEL_LOW);
Acked-by: Patrice Chotard <[email protected]>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
