On Wed, Sep 24, 2014 at 09:21:51PM +0200, Paul Bolle wrote: > Hexagon's primary Kconfig entry has a select for NO_IOPORT_MAP. But > because hexagon never defines a Kconfig symbol NO_IOPORT_MAP this select > is a nop. It can be removed. > > Perhaps hexagon should add its own Kconfig entry for NO_IOPORT_MAP and > have it default to 'y'. But since no one apparently had any problems > with HAS_IOPORT_MAP defaulting to 'y' on hexagon, as it currently does, > that is unlikely. > > Signed-off-by: Paul Bolle <[email protected]> > --- > Tested by playing with arch/hexagon/configs/comet_defconfig. After "make > oldconfig" the .config contains CONFIG_HAS_IOPORT_MAP=y both before and > after this patch, as is expected. > > Actually, the only difference I found in the .config file was that after > this patch the .config file contained > CONFIG_HEXAGON=y > > I have no idea why. Did I botch my test? > > arch/hexagon/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig > index 4dc89d1f9c48..f1817eae107a 100644 > --- a/arch/hexagon/Kconfig > +++ b/arch/hexagon/Kconfig > @@ -19,7 +19,6 @@ config HEXAGON > select GENERIC_IRQ_SHOW > select HAVE_ARCH_KGDB > select HAVE_ARCH_TRACEHOOK > - select NO_IOPORT_MAP > select GENERIC_IOMAP > select GENERIC_SMP_IDLE_THREAD > select STACKTRACE_SUPPORT > -- > 1.9.3 >
There seemed to be a convoluted history behind the ioport options, but yes this is no longer needed/doesn't actually do anything. Thanks! Acked-by: Richard Kuo <[email protected]> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
