On 10/01/2014 10:16 PM, David Rientjes wrote: >> On 09/29/2014 05:30 AM, Xiubo Li wrote: >> > Setting 'flags' to zero will be certainly a misleading way to avoid >> > warning of 'flags' may be used uninitialized. uninitialized_var is >> > a correct way because the warning is a false possitive. >> >> Agree. >> >> > Signed-off-by: Xiubo Li <li.xi...@freescale.com> >> >> Acked-by: Vlastimil Babka <vba...@suse.cz> >> > > I thought we just discussed this when > mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was > merged and, although I liked it, it was stated that we shouldn't add any > new users of uninitialized_var().
Yeah but that discussion wasn't unfortunately CC'd on mailing lists. And my interpretation of the outcome is that maybe we should try :) Also note that Arnd sent this kind of fix first, but that thread missed mailing lists as well. CCing him at least. Vlastimil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
