Heya, please check if this is OK. This was while looking the set of methods used by rasd, trying to reduce it to the bare minimum.
Perhaps even that cpu_map__new() one can be ditched, leaving to use the default of a NULL cpumap that will end up being one with -1, i.e. all cpus. - Arnaldo >From 8dc34bd2824c7843182f4fc6deabaf573e42e806 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo <[email protected]> Date: Mon, 6 Oct 2014 15:43:42 -0300 Subject: [PATCH] rasd: Use perf_evlist__open() instead of open coded equivalent Cc: Borislav Petkov <[email protected]> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> --- src/rasd.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/rasd.c b/src/rasd.c index 06ccdcdd9d56..fb33fca131fa 100644 --- a/src/rasd.c +++ b/src/rasd.c @@ -241,7 +241,6 @@ static void daemonize(void) int main() { - struct perf_evsel *c; struct thread_map *threads; struct cpu_map *cpus; int i; @@ -278,12 +277,9 @@ int main() perf_evlist__set_maps(evlist, cpus, threads); /* Open events */ - evlist__for_each(evlist, c) { - /* On all online cpus by default, system wide tracing */ - if (perf_evsel__open(c, evlist->cpus, NULL) < 0) - err("opening tracepoint, are you root?"); - } - perf_evlist__set_id_pos(evlist); + /* On all online cpus by default, system wide tracing */ + if (perf_evlist__open(evlist) < 0) + err("opening tracepoint, are you root?"); /* mmap buffers */ if (perf_evlist__mmap(evlist, 4 /* opts->mmap_pages */, false) < 0) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
