On Wed, Oct 08, 2014 at 12:21:55PM +0100, Will Deacon wrote: > On Wed, Oct 08, 2014 at 07:51:54AM +0100, Arun Chandran wrote: > > On Tue, Oct 7, 2014 at 7:13 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > > > I wasn't able to spot where the randomness came from in the > > > ARCH_BINFMT_ELF_RANDOMIZE_PIE case, so it's not clear to me if the > > > generic implementation behaves identically other than disabling > > > randomization when told to via proc. > > > > I also don't know from where it is coming; but it works on arm and x86 :) > > The randomness will come from elf_map, since that will descend into the mmap > code and end up with a randomised base address (see mmap_base and > arch_pick_mmap_layout).
Given that, it sounds like the existing randomize_et_dyn is redundant? If so, the patch looks sane to me. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
