On Thu, Oct 09, 2014 at 07:18:03AM -0700, Joe Perches wrote:
> On Thu, 2014-10-09 at 15:38 +0200, Takashi Iwai wrote:
> > At Thu, 9 Oct 2014 15:06:37 +0530,
> > Sudip Mukherjee wrote:
<snip>
> > > diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
> []
> > > @@ -48,10 +48,10 @@ static void vortex_fix_latency(struct pci_dev *vortex)
> > > {
> > > int rc;
> > > if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) {
> > > - pr_info( CARD_NAME
> > > + dev_info(&vortex->dev, CARD_NAME
> > > ": vortex latency is 0xff\n");
> >
> > Omit the superfluous prefix when converting to dev_info() & co.
> > Other than that, looks good to me.
>
> Hi Sudip.
>
> Probably all the uses of CARD_NAME and "vortex" singly and
> in combination should be removed in all these conversions.
>
Hi Takashi and Joe,
I knew Takashi will ask to remove the CARD_NAME , so i have looked at the
possibility while modifying the code.
CARD_NAME will be "Aureal Advantage" or "Aureal Vortex" or "Aureal Vortex 2"
based on which chip is defined.
So I thought, if we remove the prefix then we will not get the exact card name.
dev_* will print the device name as
CARD_NAME_SHORT which will be au8810 or au8820 or au8830.
so, now waiting for your suggestion ..
thanks
sudip
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
