On Fri, Oct 10, 2014 at 08:03:07AM -0700, Joe Perches wrote: > On Fri, 2014-10-10 at 13:31 +0530, Akshay Sarode wrote: > > ERROR: "foo* bar" should be "foo *bar" > > ERROR: do not initialise statics to 0 or NULL > > CHECK: spinlock_t definition without comment > > Signed-off-by: Akshay Sarode <[email protected]> > [] > > diff --git a/drivers/net/ethernet/nvidia/forcedeth.c > > b/drivers/net/ethernet/nvidia/forcedeth.c > [] > > @@ -911,12 +913,18 @@ enum { > [] > > /* > > * Debug output control for tx_timeout > > */ > > -static bool debug_tx_timeout = false; > > +enum { > > + NV_DEBUG_TX_TIMEOUT_DISABLED, > > + NV_DEBUG_TX_TIMEOUT_ENABLED > > +}; > > + > > +static bool debug_tx_timeout = NV_DEBUG_TX_TIMEOUT_DISABLED; > > Adding this enum is not useful. > Sorry, If I may have not checked the code properly. I am a newbie here and I was hoping to start with checking coding styles. I'll check again. Also there are a whole lot of warnings for line over 80 characters.
Regards, Akshay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
