On Mon, 2014-10-20 at 20:46 -0400, Prarit Bhargava wrote:
>
> On 10/20/2014 07:11 PM, Joe Perches wrote:
> > On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote:
> >> I tested this using both lower and upper case 'c' with the following commit
> >> text:
> > []
> >
> > I think the patch subject be something like:
> >
> > "[PATCH] checkpatch: improve commit id/desc style checking in commit
> > message"
> >
> > The [v2] goes in the subject like this:
> >
> > "[PATCH V2] checkpatch: ..."
> >
> >> 11 chars, SHOULD FAIL
> >> commit 1234567890a
> >
> > []
> >
> >> ERROR: Please use 12 or more chars for the git commit ID
> >> commit 1234567890a
> >
> > I'd expect these messages to mention something about the
> > missing commit description too.
>
> Hmm ... is that a requirement here?
Yes
> Currently checkpatch.pl doesn't complain about that.
Yes, it does
$ ./scripts/checkpatch.pl 0001-part-1.patch
ERROR: Please use 12 or more chars for the git commit ID like: 'commit
01234567890ab ("commit description")'
#9:
commit 1234567, asdf
ERROR: Please use 12 or more chars for the git commit ID like: 'commit
01234567890ab ("commit description")'
#11:
commit 123457
> I can do it but I'd hate to find out that I'm ERRORing on something
> that is considered okay to do.
It's not, you've changed output.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
