On 10/23/2014 10:16 AM, Alexandre Courbot wrote: > Add the new flags argument to calls of (devm_)gpiod_get*() and > remove any direction setting code afterwards. > > Currently both forms (with or without the flags argument) > are valid thanks to transitional macros in > <linux/gpio/consumer.h>. These macros will be removed once > all consumers are updated and the flags argument will become > compulsary. > > Signed-off-by: Alexandre Courbot <[email protected]>
It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this: Acked-by: Andrzej Hajda <[email protected]> -- Regards Andrzej > --- > drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c > b/drivers/gpu/drm/panel/panel-s6e8aa0.c > index b5217fe37f02..6427aa187735 100644 > --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c > +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c > @@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi) > return ret; > } > > - ctx->reset_gpio = devm_gpiod_get(dev, "reset"); > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > if (IS_ERR(ctx->reset_gpio)) { > dev_err(dev, "cannot get reset-gpios %ld\n", > PTR_ERR(ctx->reset_gpio)); > return PTR_ERR(ctx->reset_gpio); > } > - ret = gpiod_direction_output(ctx->reset_gpio, 1); > - if (ret < 0) { > - dev_err(dev, "cannot configure reset-gpios %d\n", ret); > - return ret; > - } > > ctx->brightness = GAMMA_LEVEL_NUM - 1; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
