On Thu, Oct 23, 2014 at 01:47:37AM +0200, Hartmut Knaack wrote: > Sudip Mukherjee schrieb am 22.10.2014 06:21: > > On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote: > >> This fixes the 2 checkpatch.pl warnings: > >> WARNING: line over 80 characters > >> > > please check your patch with --strict option of checkpatch.pl , and you > > will get : > > "Alignment should match open parenthesis" . > > > Good point, but what solution would you propose? when you are breaking the line , make a point to align the next line with the open parenthesis. like : - mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */ + mxs_lradc_reg_wrt(lradc, + LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
I have seen in many patches Greg commenting to resend the patch after aligning it. so my opinion , even though it is optional , better to use it while sending a patch , so that no one can say about that. happened to me in few of my initial patches. :) > > thanks > > sudip > > > >> Signed-off-by: Brian Vandre <bvan...@gmail.com> > >> --- > >> drivers/staging/iio/adc/mxs-lradc.c | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c > >> b/drivers/staging/iio/adc/mxs-lradc.c > >> index 32a1926..62449a6 100644 > >> --- a/drivers/staging/iio/adc/mxs-lradc.c > >> +++ b/drivers/staging/iio/adc/mxs-lradc.c > >> @@ -455,7 +455,8 @@ static void mxs_lradc_setup_ts_channel(struct > >> mxs_lradc *lradc, unsigned ch) > >> * SoC's delay unit and start the conversion later > >> * and automatically. > >> */ > >> - mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC > >> */ > >> + mxs_lradc_reg_wrt(lradc, > >> + LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */ > >> LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */ > >> LRADC_DELAY_KICK | > >> LRADC_DELAY_DELAY(lradc->settling_delay), > >> @@ -513,7 +514,8 @@ static void mxs_lradc_setup_ts_pressure(struct > >> mxs_lradc *lradc, unsigned ch1, > >> * SoC's delay unit and start the conversion later > >> * and automatically. > >> */ > >> - mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC > >> */ > >> + mxs_lradc_reg_wrt(lradc, > >> + LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */ > >> LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */ > >> LRADC_DELAY_KICK | > >> LRADC_DELAY_DELAY(lradc->settling_delay), LRADC_DELAY(2)); > >> -- > >> 1.9.1 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >> the body of a message to majord...@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
