On Tue, Oct 28, 2014 at 11:26:27AM +0000, Qais Yousef wrote: > +/* Control Device Sysfs Attributes */ > +/* version */ > +static ssize_t show_version(struct device *dev, struct device_attribute > *attr, > + char *buf) > +{ > + struct axd_cmd *cmd = (struct axd_cmd *)dev->platform_data; > + int major, minor, patch; > + > + axd_cmd_get_version(cmd, &major, &minor, &patch); > + return sprintf(buf, "%u.%u.%u\n", major, minor, patch); > +} > +static DEVICE_ATTR(version, RD_PERMS, show_version, NULL);
DEVICE_ATTR_RO() please. Same for all other instances, you should never use DEVICE_ATTR() anymore. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/