On 2014/10/30 16:55, Artem Bityutskiy wrote: > On Sat, 2014-10-25 at 19:43 +0200, Richard Weinberger wrote: >> This is more a cosmetic change than a fix. >> By using ubi_eba_atomic_leb_change() >> we can guarantee that the first VTBL record is always >> correct and we don't really need the second one anymore. >> But we have to keep the second one to not break anything. >> >> Signed-off-by: Richard Weinberger <[email protected]> > > Yeah, this atomic change stuff was added later, and we had not > envisioned originally. Your patch adds robustness, but makes volume > creation slower, which is probably not a problem. > > I've added a small comment and pushed it, thanks! > > Artem > >
Hi Artem and Richard, We are using atomic operation, leb_change(), for master_node in ubifs-level. We use two lebs for master_node even if they are changed with atomic operation. I think volume_table and master_node play similar roles. Do you think changing VTBL record into one peb is OK? I just what to know if I missed something. Could you please take some time to explain that? Thanks very much~! Hu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
