On Tue, 5 April 2005 17:26:31 +0100, Paulo Marques wrote: > > Would this be a good thing to clean up, or isn't it worth the effort at all?
I would welcome such a stream of patches. But in spite of the calloc interface being rather stupid, I'd prefer to see patches with kcalloc instead of kmalloc_zero. > --- ./lib/kobject_uevent.c.orig 2005-04-05 16:39:09.000000000 +0100 > +++ ./lib/kobject_uevent.c 2005-04-05 17:01:26.000000000 +0100 > @@ -234,10 +234,9 @@ void kobject_hotplug(struct kobject *kob > if (!action_string) > return; > > - envp = kmalloc(NUM_ENVP * sizeof (char *), GFP_KERNEL); > + envp = kmalloc_zero(NUM_ENVP * sizeof (char *), GFP_KERNEL); > if (!envp) > return; > - memset (envp, 0x00, NUM_ENVP * sizeof (char *)); > > buffer = kmalloc(BUFFER_SIZE, GFP_KERNEL); > if (!buffer) J�rn -- There's nothing better for promoting creativity in a medium than making an audience feel "Hmm � I could do better than that!" -- Douglas Adams in a slashdot interview - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
