On Fri, Oct 31, 2014 at 1:33 PM, <[email protected]> wrote: > On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: >> This is useful for reporting various addresses or other values while >> debugging early boot. >> >> Signed-off-by: Kees Cook <[email protected]> > > You haven't provided any user of this function. I don't think this > should get merged without a caller (nor should an artificial caller be > added). What's your use case for adding this?
I'll fix that. > Also, while I realize __putstr already has this problem, ideally all the > printing functions in this file should go in some separate source file > that gets omitted when !CONFIG_PRINTK (or possibly > !CONFIG_EARLY_PRINTK). Hm, I don't agree: we need error_putstr, not just debug_putstr, and early_printk is just for serial console, where as __putstr works against the boot block's defined video area too, IIUC. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
