On Mon, 3 Nov 2014, Andy Lutomirski wrote:
> On Mon, Nov 3, 2014 at 12:31 PM, Thomas Gleixner <[email protected]> wrote:
> > On Wed, 29 Oct 2014, Andy Lutomirski wrote:
> >
> >> vsyscall_64.c is just vsyscall emulation. Tidy it up accordingly.
> >>
> >> If my comment editing offends anyone, let me know and I can fix it.
> >>
> >> Reviewed-by: Josh Triplett <[email protected]>
> >> Signed-off-by: Andy Lutomirski <[email protected]>
> >> ---
> >> arch/x86/kernel/vsyscall_64.c | 51
> >> +++++++++++++++----------------------------
> >> 1 file changed, 18 insertions(+), 33 deletions(-)
> >>
> >> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
> >> index 2d912629c96e..ee622f8183f3 100644
> >> --- a/arch/x86/kernel/vsyscall_64.c
> >> +++ b/arch/x86/kernel/vsyscall_64.c
> >> @@ -1,52 +1,37 @@
> >> /*
> >> - * Copyright (C) 2001 Andrea Arcangeli <[email protected]> SuSE
> >> - * Copyright 2003 Andi Kleen, SuSE Labs.
> >> + * Mostly copyright (c) 2012-2014 Andy Lutomirski <[email protected]>
> >
> > We usualy leave the old copyright notices around even if the code
> > which is related to them has been removed more or less completely.
> >
> > So I change this to:
> >
> > /*
> > * Copyright (c) 2012-2014 Andy Lutomirski <[email protected]>
> > *
> > * Based on the original implementation:
> > * Copyright (C) 2001 Andrea Arcangeli <[email protected]> SuSE
> > * Copyright 2003 Andi Kleen, SuSE Labs.
> >
> > and apply the whole lot.
>
> Would it make more sense to move those copyright notices to
> arch/x86/vdso/vma.c? That's where most of the code ended up.
That has already a notice from Andi and I cant figure out what parts
of that have been written by Andrea. We'll worry about that when we
remove vsyscall_64.c. Until then the git history will be our friend.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
