On Mon, 03 Nov 2014, Andy Shevchenko wrote: > MFD core already cares about failing registration. It will remove successfully > registered devices in case of error. Thus, no need to repeatedly call > mfd_remove_devices(). > > Fixes: 5829e9b64e65 (mfd: lpc_sch: Accomodate partial population of the MFD > devices) > Signed-off-by: Andy Shevchenko <[email protected]> > --- > drivers/mfd/lpc_sch.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)
Applied, thanks. > diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c > index c980da4..5c38df3 100644 > --- a/drivers/mfd/lpc_sch.c > +++ b/drivers/mfd/lpc_sch.c > @@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev *dev, const > struct pci_device_id *id) > return -ENODEV; > } > > - ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, > NULL); > - if (ret) > - mfd_remove_devices(&dev->dev); > - > - return ret; > + return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, > NULL); > } > > static void lpc_sch_remove(struct pci_dev *dev) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
