On Wed, Nov 05, 2014 at 01:47:19AM +0200, Giedrius Statkevicius wrote: > Remove a variable because it only holds the results of a function call > and then gets returned so instead just return the result of a function > call. > > Signed-off-by: Giedrius Statkevičius <[email protected]> > --- > drivers/platform/x86/hp-wireless.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/hp-wireless.c > b/drivers/platform/x86/hp-wireless.c > index 415348f..670c62b 100644 > --- a/drivers/platform/x86/hp-wireless.c > +++ b/drivers/platform/x86/hp-wireless.c > @@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 > event) > > static int hpwl_add(struct acpi_device *device) > { > - int err; > - > - err = hp_wireless_input_setup(); > - return err; > + return hp_wireless_input_setup();
Since acpi_device_probe() does not print a warning if add() fails, it might be preferable to print the message here, rather than ignoring it completely. Rafael? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
