Hi Neil, On Sat, Nov 08, 2014 at 10:37:07AM +1100, NeilBrown wrote: > > > If a key is to be used for wake-up, we must not disable > the interrupt during suspend. > > Signed-off-by: NeilBrown <ne...@suse.de> > > diff --git a/drivers/input/keyboard/gpio_keys.c > b/drivers/input/keyboard/gpio_keys.c > index 8c98e97f8e41..0b5e54ae343e 100644 > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -526,6 +526,8 @@ static int gpio_keys_setup_key(struct platform_device > *pdev, > */ > if (!button->can_disable) > irqflags |= IRQF_SHARED; > + if (button->wakeup) > + irqflags |= IRQF_NO_SUSPEND;
No, enable_irq_wake() should be enough. I believe Rafael has fixed that in the core, right? > > error = devm_request_any_context_irq(&pdev->dev, bdata->irq, > isr, irqflags, desc, bdata); Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
