On 11/09/2014 05:11 PM, Joe Perches wrote: > On Sun, 2014-11-09 at 16:58 +0800, Chen Gang wrote: >> In header file, "extern inline" may cause multiple definition, so need >> change it to "static inline". And also need be quoted by __GNUC__ for >> they are as inline functions only for __GNUC__. > [] >> diff --git a/lib/mpi/mpi-inline.h b/lib/mpi/mpi-inline.h > [] >> @@ -30,7 +30,7 @@ >> #define G10_MPI_INLINE_H >> >> #ifndef G10_MPI_INLINE_DECL >> -#define G10_MPI_INLINE_DECL extern inline >> +#define G10_MPI_INLINE_DECL static inline > > Why not remove the #define and use static inline > in the 4 places the #define is currently used? >
I just follow the original author's ways, the original author may think it is useful. I guess, it may be used by other systems (neither Linux kernel nor gcc). For another compiler, it may need another syntax for it (although I am not quite sure about it). So for safety reason, still keep it no touch, at present. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
