At Fri, 14 Nov 2014 18:12:21 +0530, Sudip Mukherjee wrote: > > earlier we were ignoring the return value of snd_ak4114_create and > always returning 0. > now we are returning the actual status. revo_init is calling this > function, and revo_init is checking the return value. > > Signed-off-by: Sudip Mukherjee <[email protected]> > --- > > change in v3: spec->ak4114 is now dereferenced if we dont get an > error value from snd_ak4114_create. > > change in v4: error value returned according to coding style.
Applied but I had to fix your From address (two others, too). That doesn't match with your sign-off. Please fix your git config to have a proper author address as same as sign-off. thanks, Takashi > > sound/pci/ice1712/revo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c > index 1112ec1..1d81ae6 100644 > --- a/sound/pci/ice1712/revo.c > +++ b/sound/pci/ice1712/revo.c > @@ -494,11 +494,13 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) > ap192_ak4114_write, > ak4114_init_vals, ak4114_init_txcsb, > ice, &spec->ak4114); > + if (err < 0) > + return err; > /* AK4114 in Revo cannot detect external rate correctly. > * No reason to stop capture stream due to incorrect checks */ > spec->ak4114->check_flags = AK4114_CHECK_NO_RATE; > > - return 0; /* error ignored; it's no fatal error */ > + return 0; > } > > static int revo_init(struct snd_ice1712 *ice) > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
