On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote: > irq_of_parse_and_map() returns 0 on error, so testing for negative > result never works. > > Signed-off-by: Dmitry Torokhov <d...@chromium.org>
Good catch, thanks!
Acked-by: James Hogan <james.ho...@imgtec.com>
A quick coccinelle script shows up numerous other cases of this error
around the kernel tree too...
Cheers
James
> ---
>
> Not tested, found by casual inspection of the code.
>
> drivers/gpio/gpio-tz1090.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
> index 9e90177..e3024bb 100644
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct
> tz1090_gpio_bank_info *info)
> bank->irq = irq_of_parse_and_map(np, 0);
>
> /* The interrupt is optional (it may be used by another core on chip) */
> - if (bank->irq < 0) {
> + if (!bank->irq) {
> dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
> info->index);
> return 0;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
signature.asc
Description: Digital signature
